Repository navigation
[Nightly]: 2026.17 perfomance. - #9107
Merged
Merged
Conversation
…detailed documentation
Introduce PUT /api/1.1/tasks/{id} for COMPLETED status, gated by
TASK_UPDATE_V1_1_ENABLED, with optional raw token persistence behind
TOKEN_PERSISTENCE_RAW_ENABLED.
https://processmaker.atlassian.net/browse/FOUR-32800
Batch-load listing relations after pagination to avoid per-row queries for process version alternative, active tasks, process categories, and project assets while preserving the existing API response shape. - Add ProcessRequestListingRawRepository to hydrate activeTasks (raw SQL) and process data (Eloquent + batched projects/categories) - Use withAggregate for process_version_alternative and read it without lazy-loading ProcessVersion - Add activeTasks relation and use preloaded data in ProcessRequests - Preload projects JSON and reuse loaded categories in Process accessors - Apply hydration in index and getRequestsByCase - Add bounded query-count feature test https://processmaker.atlassian.net/browse/FOUR-32947
feat(FOUR-32801): improve Jobs execution when the PUT tasks endpoint is executed
feat(FOUR-32800): add v1.1 task completion endpoint with raw SQL path
FOUR-32800: test compares legacy and optimized
devmiguelangel
approved these changes
Nov 12, 2026
Split resolveDraftPayloadForToken for Sonar S1142 and extract draftIdFromPayload to clear nested ternary S3358 without changing draft authorization behavior. https://processmaker.atlassian.net/browse/FOUR-34369
Passing null into applyProcessIndexPmql triggered a TypeError after the Sonar refactor added a string type hint; normalize pmql before the call. https://processmaker.atlassian.net/browse/FOUR-34369
…ForToken Merge token and draft early-exit guards for Sonar S1142 without changing draft authorization behavior. https://processmaker.atlassian.net/browse/FOUR-34369
… includes Nested draft includes (e.g. processRequest.tokens.draft) no longer eager-load, resolve, or delete the parent task draft when only nested paths are requested. Root draft.* includes still use constrained eager load with nested relations (draft.media). https://processmaker.atlassian.net/browse/FOUR-34369
… parsing Strip :* and :col from include paths so nested draft eager loads and sanitization apply to processRequest.tokens.draft:* variants; redact nested drafts defensively when serialized token trees contain draft payloads. https://processmaker.atlassian.net/browse/FOUR-3436fix(FOUR-34369): treat Laravel include column suffixes in draft token parsing Strip :* and :col from include paths so nested draft eager loads and sanitization apply to processRequest.tokens.draft:* variants; redact nested drafts defensively when serialized token trees contain draft payloads. https://processmaker.atlassian.net/browse/FOUR-343699
… disabled Nested draft redaction suppresses payload without deleting rows; root include=draft retains legacy delete-on-access for assignees. https://processmaker.atlassian.net/browse/FOUR-34369
…e drafts for managers When task drafts are disabled, process managers listing with processRequest.tokens.draft must not remove other assignees' task_drafts rows. https://processmaker.atlassian.net/browse/FOUR-34369
Avoid per-row token queries on optimized index when draft is included; prefetch nested token rows for redaction and cache process manager ids. https://processmaker.atlassian.net/browse/FOUR-34369
…o assignee Reject serialized token policy fields, require authoritative attrs on root resource, and avoid deleting assignee drafts when managers list with include=draft while drafts are disabled. https://processmaker.atlassian.net/browse/FOUR-34369
test(cache): enable metrics in ScreenCacheFactoryTest setUp refactor(FOUR-34369): reduce Sonar complexity in TaskResourceIncludes https://processmaker.atlassian.net/browse/FOUR-34369
fix(FOUR-34369): eager-load processRequest.process in optimized index…
…s present Delete scheduled_tasks after TokenPersistenceRawRepository::saveClosedToken so raw SQL matches ProcessRequestTokenObserver on CLOSED tokens. When BROWSER_CACHE is false, apply no-store to cacheable responses unless Cache-Control already includes private and must-revalidate (Tasks page shell).
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 85c0dc9. Configure here.
Delete scheduled_tasks after TokenPersistenceRawRepository::saveClosedToken so raw token closes match ProcessRequestTokenObserver on CLOSED tokens. When BROWSER_CACHE is false, skip responses that already send private and must-revalidate (Tasks page shell). Apply private, no-cache, must-revalidate when an ETag is present so HandleEtag routes can still use If-None-Match. Otherwise apply no-store on cacheable GET/HEAD bodies with content.
Reuse TaskDraft models already bound to the token during sanitization instead of re-querying id, task_id, and data. Load missing draft data onto the same instance so paths such as draft.media keep eager-loaded relations and avoid redundant per-row queries.
gproly
approved these changes
Nov 13, 2026
Satisfy php:S1142 by collapsing five early returns into a single exit. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Issue & Reproduction Steps
In this branch already merge all the changes related to the perfomance staff
Related Tickets & Packages
Code Review Checklist
PR Packages
ProcessMaker/screen-builder#1917
ProcessMaker/vue-form-elements#475
https://github.com/ProcessMaker/package-savedsearch/pull/706